Update to bdk 0.17.0 - Githubissues

bitcoindevkit / bdk-cli

A CLI wallet library and REPL tool to demo and test the BDK library

Other

111 stars 65 forks source link

Update to bdk 0.17.0 #73

Closed notmandatory closed 2 years ago

notmandatory commented 2 years ago

Description

Fixes #81

Notes to the reviewers

Also added verify feature flag which enables transaction verification against consensus rules during sync.

I also had to disable the reserves tests and that feature will be broken until we can get it updated to use bdk 0.17 also. I created an issue https://github.com/weareseba/bdk-reserves/issues/4.

Checklists

All Submissions:

[x] I've signed all my commits
[x] I followed the contribution guidelines
[x] I ran cargo fmt and cargo clippy before committing

New Features:

[ ] I've added tests for the new feature
[ ] I've added docs for the new feature
[x] I've updated CHANGELOG.md

rajarshimaitra commented 2 years ago

I just saw your PR after making the issue.. Looks like you are already on it.. I will review once its ready.. Lets get this one done first..

rajarshimaitra commented 2 years ago

@notmandatory let me know if you want me to take this on if you are busy in other parts.. I can try push it to finish line..

notmandatory commented 2 years ago

Thanks Raj! it's ready to review now I'd appreciate your review.