Fetch address index in verbose mode for get_new_address

bitcoindevkit / bdk-cli

A CLI wallet library and REPL tool to demo and test the BDK library

Other

108 stars 64 forks source link

Fetch address index in verbose mode for get_new_address #77

Closed rajarshimaitra closed 2 years ago

rajarshimaitra commented 2 years ago

Description

Fixes #40

cc @thunderbiscuit

Checklists

All Submissions:

[x] I've signed all my commits
[x] I followed the contribution guidelines
[x] I ran cargo fmt and cargo clippy before committing

New Features:

[ ] I've added tests for the new feature
[ ] I've added docs for the new feature
[ ] I've updated CHANGELOG.md

rajarshimaitra commented 2 years ago

@notmandatory does this requires changelog update?

thunderbiscuit commented 2 years ago

tested ACK 73a9824.

thunderbiscuit commented 2 years ago

Related but not related question: I think the verbose flag is not available in the repl. Is that something we could enable?

rajarshimaitra commented 2 years ago

I haven't tried yet but from the code it seems verbose mode should be available to repl too..

https://github.com/bitcoindevkit/bdk-cli/blob/c20eb5a2651e2b594c9e9ea1bd84bf84b0c586d1/src/bdk_cli.rs#L342

Let me know if that's not the case.. Then it might need some fixing..

thunderbiscuit commented 2 years ago

You're right. Took me a minute to figure it out, but my mistake was trying to call --verbose inside the repl (which throws an error). Instead the --verbose flag needs to be enabled when entering the repl, and will be "on" for all commands inside the loop.

Thanks!