bitcoindevkit / bdk-ffi

Please consider this project *experimental*. But we hope to have an official release out soon.
Other
88 stars 39 forks source link

Dependency signature verification for bdk-swift #368

Open reez opened 1 year ago

reez commented 1 year ago

Describe the enhancement
Digitally sign xcframework for bdk-swift.

Use case
Developers using bdk-swift will be able to verify xcframework is digitally signed.

Additional context In Xcode 15 Apple will show whether the framework has been digitally signed or not.

Currently the bdk-swift xcframework would look like this in Xcode 15, "unsigned":

Screenshot 2023-06-09 at 10 36 16 AM

Apple references:

thunderbiscuit commented 1 year ago

Cool! Let me know if you need the GPG keys for the signature (is it done in the CI? that's what it is for the Kotlin libraries).

reez commented 1 year ago

Cool! Let me know if you need the GPG keys for the signature (is it done in the CI? that's what it is for the Kotlin libraries).

Sweet! Yeah it looks just like a one line command we can do in the CI. I’ll go see what you all do in Kotlin since you do it there, just because I’m interested in how that works-

reez commented 10 months ago

I think the only hangup here is the need to have an Apple Distribution certificate to sign with (which I'm not sure if we have or not)

reez commented 4 months ago

We have an Apple Developer account now so we should have all the pieces in place to do this when it's risen to the top of the priority list-

thunderbiscuit commented 4 months ago

Sounds good let's do it!