Still need to be brought back for 1.0

bitcoindevkit / bdk-ffi

Please consider this project *experimental*.

Other

90 stars 43 forks source link

Still need to be brought back for 1.0 #522

Open thunderbiscuit opened 6 months ago

thunderbiscuit commented 6 months ago

This issue compiles a list of structs and methods that were commented out in the move to the 1.0 early releases in order to keep track of what we probably want to bring back, without having to keep them as comments in the codebase.

[x] TxIn type
[x] Payload type (doesn't exist anymore)
[x] Address.from_script() method
[ ] Address.payload() method
[x] Transaction.lock_time()
[x] Transaction.input()
[x] Transaction.output()
[x] Psbt.txid() (not there anymore)
[x] Psbt.combine()
[x] Psbt.fee_amount() (renamed to fee())
[x] Psbt.fee_rate() (not there anymore)
[x] Psbt.json_serialize()
[ ] SignOptions
[ ] TxBuilder.add_data()

jurvis commented 5 months ago

hi @thunderbiscuit, we still need Transaction – input() and output() and conversely from 1, the TxIn type.

does .finalize_psbt not require SignOptions as a parameter anymore?

thunderbiscuit commented 5 months ago

We didn't have the Wallet.finalize_psbt() method before (or at least I can't find it anywhere), but you might be referring to the Wallet.sign() method? The sign() method still takes a SignOptions parameter in Rust, but for the bindings we simply pass the default version of that (and have removed it as a parameter). Did you use it to customize the signer options? I'm happy to try to add it back for you next week if you'd like and need it.

andreasgriffin commented 3 months ago

get_height (the current blockchain tip) is missing. It also seems to have vanished from the esplora and electrum client. This is however very useful.

andreasgriffin commented 3 months ago

The RPC client would be great!