search

bitcoindevkit / bdk-ffi

Please consider this project *experimental*.
Other
87 stars 42 forks source link

MacOS Build Error #573

Open keith-gardner opened 3 months ago

keith-gardner commented 3 months ago

Describe the bug
Symbolic Links missing, as required for App Store.

Hello,

We noticed one or more issues with a recent delivery for the following app:
...
Please correct the following issues and upload a new binary to App Store Connect.

ITMS-90291: Malformed Framework - The framework bundle bdkFFI (AppName.app/Contents/Frameworks/bdkFFI.framework) must contain a symbolic link 'bdkFFI' -> 'Versions/Current/bdkFFI'. Refer to the [Anatomy of Framework Bundles](http://developer.apple.com/library/mac/#documentation/MacOSX/Conceptual/BPFrameworks/Concepts/FrameworkAnatomy.html) for more information.

ITMS-90291: Malformed Framework - The framework bundle bdkFFI (AppName.app/Contents/Frameworks/bdkFFI.framework) must contain a symbolic link 'Resources' -> 'Versions/Current/Resources'. Refer to the [Anatomy of Framework Bundles](http://developer.apple.com/library/mac/#documentation/MacOSX/Conceptual/BPFrameworks/Concepts/FrameworkAnatomy.html) for more information.

ITMS-90292: Malformed Framework - The framework bundle bdkFFI (AppName.app/Contents/Frameworks/bdkFFI.framework) 'Versions' directory must contain a symbolic link 'Current' resolving to a specific version directory. Resolved link target: '${linkTarget}'. Refer to the [Anatomy of Framework Bundles](http://developer.apple.com/library/mac/#documentation/MacOSX/Conceptual/BPFrameworks/Concepts/FrameworkAnatomy.html) for more information.

To Reproduce

  1. Install bdk-swift following https://github.com/bitcoindevkit/bdk-swift?tab=readme-ov-file#how-to-use
  2. Archive Mac OS with bdk-swift and submit to app store

Expected behavior
Expecting no build errors.

Build environment

reez commented 3 months ago

Thanks @keith-gardner! Can you let me know what Xcode version you're using as well?

keith-gardner commented 3 months ago

Thanks @keith-gardner! Can you let me know what Xcode version you're using as well?

Version 15.4 (15F31d)

keith-gardner commented 3 months ago

Will be in Nashville next week, happy to go through in person

reez commented 3 months ago

Great ya lets connect in person for sure!

BDK 1.0 beta is right around the corner too so if you all have been playing around with any of our bdk-ffi alpha releases and have any questions or thoughts on 1.0 I'd love to chat on that as needed as well-

keith-gardner commented 3 months ago

Want to join @brantaops on Telegram, like our last message and I'll text you? Will delete this comment after

Also have Signal 👍

reez commented 3 months ago

Want to join @BrantaOps on Telegram, like our last message and I'll text you? Will delete this comment after

Also have Signal 👍

I dont have telegram, so we will have to connect either on the BDK Discord or on Signal

keith-gardner commented 3 months ago

Solid, posted in Development channel

reez commented 3 months ago

Solid, posted in Development channel

Sweet, I see ya, will DM about nashville-

reez commented 2 months ago

Great meeting you!

Xcode 15.3+ had breaking changes for a lot of projects https://github.com/firebase/firebase-ios-sdk/issues/12587, ours included https://github.com/bitcoindevkit/bdk-ffi/issues/463

We made a fix for it https://github.com/bitcoindevkit/bdk-ffi/pull/466 , via experimentation since there was no official documentation, might be what we have to do with this one too.

If you'd like to help test/fix: