Update bdk dependency to 0.22

bitcoindevkit / bdk-reserves

Proof-of-reserves for bitcoin-dev-kit

Other

15 stars 9 forks source link

Update bdk dependency to 0.22 #11

Closed notmandatory closed 2 years ago

notmandatory commented 2 years ago

This update also required recalculating the PSBT proofs due to BDK removing partial signatures, see https://github.com/bitcoindevkit/bdk-cli/pull/118#pullrequestreview-1097097244.

Once this PR is merged I'll publish a new bdk-reserves release version 0.22.0.

notmandatory commented 2 years ago

@ulrichard I did the basic changes to update to the bdk 0.22 release candidate. Do you have time to investigate why some tests are failing?

rajarshimaitra commented 2 years ago

Thanks @notmandatory for the PR.. Code changes looks good to me.. Here's the possible reason why the tests might be failing.

We changed the get_funded_wallet code in bdk, so the transaction created by get_funded_wallet looks different than before.
- Which is used in all the failing tests and then calls wallet.verify_proof() against a hardcoded PSBT here https://github.com/bitcoindevkit/bdk-reserves/blob/d4f078e58a0330bca51ae20cbaf783709522389e/src/reserves.rs#L375-L379
- This PSBT probably needs to be updated to match against the new funding transaction. But I don't fully understand how it was created. Maybe @ulrichard can help us here..

notmandatory commented 2 years ago

@rajarshimaitra thanks for the tip! yes I did have to re-calculate the proof PSBT and that fixed the tests. I think the difference is caused by the new PSBT default signing options, on finalize remove partial signatures. I didn't check the individual bits and bytes but the new PSBTs are much smaller.

ulrichard commented 2 years ago

Sorry for the late reaction. I was busy with other things. Looks all good to me. Thanks for your efforts.