bitcoindevkit / bdk-reserves

Proof-of-reserves for bitcoin-dev-kit
Other
15 stars 9 forks source link

Update tests/* to use regtest instead of testnet #14

Closed notmandatory closed 1 year ago

notmandatory commented 1 year ago

We're getting some test failures because tests are running against testnet and either the test wallets don't have sufficient funds or some network issues talking to electrum.blockstream.info. We should be able to use the electrsd crate to do these integration tests with a local regtest nodes.

ulrichard commented 1 year ago

Yes, I thought the same. Just didn't have time to implement it yet. It may also be that somebody stole the Testnet coins, as the private keys are included in the tests.

notmandatory commented 1 year ago

Not sure if it's the testnet coins getting stolen since all I had to do was re-run the tests on github to get it to work.. could also be some timeout with the github actions and/or blockstream testnet electrum. But either way best to move to regtest.

ulrichard commented 1 year ago

I started working on that: https://github.com/weareseba/bdk-reserves/tree/feature/regtest

notmandatory commented 1 year ago

Fixed by #15