bitcoindevkit / bdk-reserves

Proof-of-reserves for bitcoin-dev-kit
Other
15 stars 9 forks source link

Create proof panics instead of returning error when the wallet has no balance #22

Closed sebastianmontero closed 1 year ago

sebastianmontero commented 1 year ago

Hi

Why is unwrap used in this line of the create_proof method, instead of returning an error? So as to allow the calling application to handle the error.

Thanks,

ulrichard commented 1 year ago

That was not intentional, but an oversight from converting the code from prototyping stage to production. Thanks for reporting.