search

bitcoindevkit / bdk-sqlx

BDK async storage implementation using sqlx + postgres or sqlite
MIT License
3 stars 9 forks source link

Consider using tokio-postgres in place of sqlx #2

Open ValuedMammal opened 2 months ago

ValuedMammal commented 2 months ago

And possibly renaming the crate along the lines of "bdk_postgres".

tvpeter commented 1 month ago

@ValuedMammal I would like to work on this.

ValuedMammal commented 1 month ago

Yeah it might be worth looking into. One thing to keep in mind is that this library should still work with any existing apps that use sqlx, so if moving to tokio-postgres causes any sort of dependency clash that could be a problem.

tvpeter commented 1 month ago

From an initial consideration, the Error::Sqlx will result in a breaking change. Except we consider returning errors from queries as Error::Sqlx.

matthiasdebernardini commented 1 month ago

I'm ok with that, the current error handling from sqlx is not that useful because when it fails it doesn't say which query fails, it just says the reason why. I have no problem with the error types changing.