bitcoindevkit / bdk

A modern, lightweight, descriptor-based wallet library written in Rust!
Other
860 stars 307 forks source link

`Indexer::index_tx` can have a default impl in the trait. #1097

Open evanlinjin opened 1 year ago

evanlinjin commented 1 year ago
          I think this is a good idea. Also `index_tx` can have a default impl in the trait.

_Originally posted by @LLFourn in https://github.com/bitcoindevkit/bdk/pull/1084#discussion_r1305441253_

vladimirfomene commented 1 year ago

@evanlinjin as discussed, I'm taking this up.

LLFourn commented 8 months ago

See https://github.com/bitcoindevkit/bdk/pull/1176#issuecomment-1928183948 why I no longer think this is a good idea.