Open LLFourn opened 1 year ago
"the PR author"
I moved this to alpha.4 since we want to get any functional changes in before a beta release.
FWIW I think this is still a good idea.
Can we postpone it to a 1.1 version @notmandatory?
I think it is okay to postpone this to after 1.0.0. I think it may simplify the API and make it cleaner to use with less foot-guns. However, it is also not critical to have this.
currently:
But it could also just be:
But we would have to give up the derive
PartialEq
onTxGraph
because I don't think we want to force indexes to implement it.The motivation is avoiding having to duplicate every mutating API on
TxGraph
toIndexedTxGraph
. We seem to have some trouble doing this. For example,IndexedTxGraph
andTxGraph
both haveinsert_tx
but they have different arguments atm but they should be the same. Also in #1041 I a method is being added toIndexedTxGraph
but it should also be onTxGraph
but the PR author forgot.The downside is that
TxGraph
would not longer be a pure data structure but since we don't use it like that I don't think this matters.