Closed ulrichard closed 4 years ago
I think this is because older versions used to depend on a specific branch of our rust-miniscript
fork. That was a dumb mistake of mine, because when you push changes to that branch, your old code won't compile anymore, and that's probably what happened here.
We switched to rev-based dependency "pinning", which instead uses the hash of a commit, so that even if you push new changes to a specific branch (as long as those commits exist in your tree) everything will compile fine.
I don't think there's really a way to fix that, I would just suggest to use master
or pin it to one of the most recent commits instead of the 0.1.0-beta.1
tag. We are also working on a new tagged release that should be ready pretty soon, if you prefer to wait for that.
Hi Alekos, thanks for the quick response. With your suggestion to use master, you mean that I use the third line (second option) of my issue above in my Cargo.toml? The errors above are from exactly this configuration.
Oh right, I didn't notice the second line. I thought you were using the old tag.
That's definitely an issue then, I'll try to work on that today.
Can you try adding this to your Cargo.toml and see if it fixes it?
[patch.crates-io]
bitcoin = { git = "https://github.com/rust-bitcoin/rust-bitcoin/", rev = "478e091" }
miniscript = { git = "https://github.com/MagicalBitcoin/rust-miniscript", rev = "d0322ac" }
This would help with the errors in bdk, but leads to errors in other dependencies that also depend on rust-bitcoin.
Yes, that would be expected. I changed the way we declare the bitcoin
and miniscript
dependencies in #123, together with the update to rust-bitcoin 0.25
. I'm expecting to merge this very soon, afterwards you will be able to use master
with no errors.
As soon as I add one of the following lines to the Cargo.toml file of my project, I get the following errors: