search

bitcoindevkit / bdk

A modern, lightweight, descriptor-based wallet library written in Rust!
Other
838 stars 300 forks source link

Esplora blockchain fails reorg test #357

Open LLFourn opened 3 years ago

LLFourn commented 3 years ago

see: https://github.com/bitcoindevkit/bdk/blob/881ca8d1e37f6cf15e78b8578979ef5c68515943/src/testutils/blockchain_tests.rs#L534

Close this issue by getting to the bottom of it and making it pass.

gabbyprecious commented 2 years ago

Hello @LLFourn is this still available?

LLFourn commented 2 years ago

Yep this is still a problem -- that line of code is still there.

notmandatory commented 2 years ago

@gabbyprecious would you rather work on this one or #518? I'd rather new folks take one issue at a time.

Gioelio commented 2 years ago

Hi, i came from summerofbitcoin and if this issue is still available i can try to fix it

notmandatory commented 2 years ago

Hi @Gioelio do you still want to work on this issue or did you take another summer of bitcoin project?

Gioelio commented 2 years ago

I tried to fix it but I didn't understand what the problem was, sorry

w3irdrobot commented 2 years ago

I have some time today to work on this. I can tackle this one if no one else is already doing it.

notmandatory commented 2 years ago

FYI I've done some research on how electrum reacts to reorgs and I think it could be related to why this and the electrum (with version 0.9.1) integration tests fail. See here: https://bitcoin.stackexchange.com/questions/114044/how-can-i-simulate-a-reorg-for-testing