search

bitcoindevkit / bdk

A modern, lightweight, descriptor-based wallet library written in Rust!
Other
807 stars 290 forks source link

BIP 329 "Wallet Labels Export Format" Support #848

Open gabridome opened 1 year ago

gabridome commented 1 year ago

The spec is new but it seems not invasive. I find particularly interesting the outputs's labels. https://github.com/bitcoin/bips/blob/master/bip-0329.mediawiki

thunderbiscuit commented 1 year ago

I like the labelling idea a lot. But in this case this might be information that would be stored in the BD itself (unless the cli kept a separate persistence of some sort), and so I think this issue is better suited for BDK itself rather than bdk-cli.

notmandatory commented 1 year ago

I agree this looks like a good spec to add support for but the feature should be added in the bdk repo, once there we can enable it in the bdk-cli tool. Moving this issue to the bdk repo for now.

xavierfiechter commented 8 months ago

What about "Label Import" ?

praveenperera commented 1 month ago

Can I help with this?

notmandatory commented 1 month ago

Hi @praveenperera yes I don't know of anyone else looking into this issue.

praveenperera commented 1 month ago

@notmandatory sounds good, the implementation looks relatively simple, I just have to familiarize myself with BDK a bit more to figure out the place to add it.

I’ll probably need this in a few weeks, so assuming no one else has picked it up by then, I’ll work on it at that time.

If someone else wants to take it before then, feel free.

notmandatory commented 1 month ago

Feel free to ask questions in our discord text or weekly voice chats too.