search

bitcoindevkit / bdk

A modern, lightweight, descriptor-based wallet library written in Rust!
Other
864 stars 311 forks source link

`rust-bitcoin` 0.30.0 upgrade may be annoying #916

Closed tcharding closed 1 year ago

tcharding commented 1 year ago

Hi,

We just released v0.30.0 of rust-bitcoin, assuming you guys are going to upgrade, can I ask a favour please. If the upgrade is painful can you please give me feedback. There is a fair bit of churn going on with crate smashing and I'd like to make it as painless as possible for downstream. I don't personally work on any code that uses rust-bitcoin so I have a tendency to get tunnel vision.

If its super painful, just prod me and I can lend a hand.

Thanks

notmandatory commented 1 year ago

Thanks, we'll also need rust-bitcoin/rust-miniscript#527 to be released, but we can still start getting a bdk PR ready.

tcharding commented 1 year ago

Oh of course, I probably should help out there first huh :)

notmandatory commented 1 year ago

Reopening this issue since @danielabrozzoni is working on it in #1023.

nondiremanuel commented 1 year ago

@notmandatory shall we close this issue? I saw that #1023 was merged

notmandatory commented 1 year ago

Yes! fixed by #1023.