search

bitcoindevkit / bitcoin-ffi

Other
12 stars 7 forks source link

lib: add `TxIn` #10

Closed rustaceanrob closed 3 weeks ago

rustaceanrob commented 1 month ago

Nothing too wild here. This mirrors what is going on in bdk-ffi and also adds the conversion from TxIn to BitcoinTxIn. Weirdly From<u32> for Sequence is not implemented otherwise this would be super clean.

reez commented 4 weeks ago

using the try_unwrap, looks good to me!

Good callout on:

Weirdly From<u32> for Sequence is not implemented otherwise this would be super clean. ... that is interesting and would end up looking clean.

rustaceanrob commented 3 weeks ago

Rebased. I also moved any std imports to be grouped, and any pub reexports to be grouped

tnull commented 3 weeks ago

This unfortunately needs another rebase now that #11 landed.

rustaceanrob commented 3 weeks ago

Rebased

rustaceanrob commented 3 weeks ago

Given the conversation on #16, I removed the Arc optimizations in favor of cloning.