feat: add address type - Githubissues

bitcoindevkit / bitcoin-ffi

Other

12 stars 7 forks source link

Closed reez closed 4 weeks ago

reez commented 1 month ago

Adding Address type.

Note

I was able to use the macros but had to add type CheckedBitcoinAddress = BitcoinAddress<NetworkChecked>; since from what I can tell the macros are not designed to handle generic types like BitcoinAddress<NetworkChecked> (let me know if I'm mistaken though or if there's a better way)

thunderbiscuit commented 4 weeks ago

I think this one is ready to go. @reez would you mind rebasing?

reez commented 4 weeks ago

This looks good! One thing I'd add is the auto-generated Display trait on Address.
[Traits=(Display)]
interface Address

this is added now, mirrored what we do in bdk-ffi

reez commented 4 weeks ago

I think this one is ready to go. @reez would you mind rebasing?

this is rebased now

thunderbiscuit commented 4 weeks ago

Tested locally on bdk-ffi and everything is smooth. CI run here.