search

bitcoindevkit / rust-electrum-client

Bitcoin Electrum client library. Supports plaintext, TLS and Onion servers.
MIT License
80 stars 62 forks source link

Upgrade bitcoin to v0.31 #121

Closed tcharding closed 12 months ago

tcharding commented 1 year ago

Upgrade bitcoin dependency to rust-bitcoin v0.31.0-rc1:

Allows us to remove the dependency on bitcoin-private because the hex stuff is exposed by bitcoin now.

EDIT: Post merge edite, the upgrade was to v0.31.0 not the rc1 release.

notmandatory commented 12 months ago

This all looks good to me, I only have one small nit, can you change your commit message to indicate this updates bitcoin to 0.31.0, it currently says 0.31.0-rc1.

tcharding commented 12 months ago

Of course, my bad.

tcharding commented 12 months ago

Force push is change of commit log only, no other changes.

tcharding commented 11 months ago

Have you got a release queued up already @notmandatory? Can you ping me, if you think of it, when it drops and I'll push on with the other upgrades. No stress, it just popped into my head.

notmandatory commented 11 months ago

I'll do a 0.19.0 release now and moved incomplete issues to future 0.20.0 release.

RCasatta commented 11 months ago

can't see the 0.19.0 release on crates?

CC @afilini @danielabrozzoni

notmandatory commented 11 months ago

I was planning to merge #128 when I'm back home on Tues and then add the 0.19.0 tag. But if someone can get to it sooner please go ahead.