bitcoindevkit / rust-electrum-client

Bitcoin Electrum client library. Supports plaintext, TLS and Onion servers.
MIT License
78 stars 63 forks source link

Client is only exported when `proxy` feature is enabled. #91

Open tnull opened 1 year ago

tnull commented 1 year ago

Currently, the default features are ["use-rustls", "proxy"]. As I have no immediate use for a socks proxy, I tried disabling this feature, with the result that crate::client is not exported anymore, see here:

https://github.com/bitcoindevkit/rust-electrum-client/blob/129081999ce96f1ed33877a2aecad4e2550764f3/src/lib.rs#L54-L58

Not sure if that is intended, but if "proxy" is indeed mandatory, it's unclear to me why it's a feature in the first place?

tnull commented 11 months ago

Recently stumbled across this again when implementing Electrum syncing for LDK. Would be great to get a resolution here: is proxy mandatory, if so, why is it a feature to begin with?

thunderbiscuit commented 1 month ago

See #143