Closed LLFourn closed 1 year ago
thanks @tnull I addressed all comments I believe.
LGTM, feel free to squash.
I squashed the commits. Sorry about the epic wait on this one.
...the CI seems to be stuck.
Hi @LLFourn, can you rebase the changes on master and force push? That will re-run the CI jobs and I'm not able to re-run them from my end.
This will need to be rebased once #31 goes in, when testing locally running tests one at a time fixed the test reliability issue for me.
sorry everyone I was pushing to the wrong branch. Should be good to go.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/async.rs | 12 | 13 | 92.31% | ||
<!-- | Total: | 46 | 47 | 97.87% | --> |
Totals | |
---|---|
Change from base Build 3702021004: | 0.9% |
Covered Lines: | 832 |
Relevant Lines: | 1027 |
Note that all the fields have been added yet. Just some useful ones that seemed important for bdk.