bitcoindevkit / rust-esplora-client

Bitcoin Esplora API client library. Supports plaintext, TLS and Onion servers. Blocking or async.
MIT License
28 stars 44 forks source link

Add /blocks API #27

Closed LLFourn closed 1 year ago

LLFourn commented 1 year ago

Note that all the fields have been added yet. Just some useful ones that seemed important for bdk.

LLFourn commented 1 year ago

thanks @tnull I addressed all comments I believe.

tnull commented 1 year ago

LGTM, feel free to squash.

LLFourn commented 1 year ago

I squashed the commits. Sorry about the epic wait on this one.

LLFourn commented 1 year ago

...the CI seems to be stuck.

vladimirfomene commented 1 year ago

Hi @LLFourn, can you rebase the changes on master and force push? That will re-run the CI jobs and I'm not able to re-run them from my end.

notmandatory commented 1 year ago

This will need to be rebased once #31 goes in, when testing locally running tests one at a time fixed the test reliability issue for me.

LLFourn commented 1 year ago

sorry everyone I was pushing to the wrong branch. Should be good to go.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3708387343


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/async.rs 12 13 92.31%
<!-- Total: 46 47 97.87% -->
Totals Coverage Status
Change from base Build 3702021004: 0.9%
Covered Lines: 832
Relevant Lines: 1027

💛 - Coveralls