feat(api): expose bitcoin types for the API

vincenzopalazzo commented 1 year ago

In some cases, you need to use the bitcoin primitive to convert a type into another format or build a type from a hex string.

This commit will reexport the primitive used in the client without forcing the caller to add the bitcoin crate as direct dependency.

The motivation to have this is when you are interacting with a system that is not rust, and you do not need the rust-bitcoin.

notmandatory commented 1 year ago

@vladimirfomene once this one is merged I think it's time for a new release for this crate. Can we do it early next week?

vladimirfomene commented 1 year ago

Yes, @notmandatory you read my mind.

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 4591020650

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 80.077%

Totals
Change from base Build 4419789814:	0.0%
Covered Lines:	832
Relevant Lines:	1039

💛 - Coveralls

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 4591020650

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 80.077%

Totals
Change from base Build 4419789814:	0.0%
Covered Lines:	832
Relevant Lines:	1039

bitcoindevkit / rust-esplora-client