bitcoindevkit / rust-esplora-client

Bitcoin Esplora API client library. Supports plaintext, TLS and Onion servers. Blocking or async.
MIT License
29 stars 44 forks source link

bugfix: `GET /tx/:txid/status` is not `Option` #46

Closed MaxFangX closed 1 year ago

MaxFangX commented 1 year ago

See the server-side handler - unlike the other tx endpoints, this one doesn't first check if the tx is known.

Also added a test that confirms this behavior.

coveralls commented 7 months ago

Pull Request Test Coverage Report for Build 4793145247

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/blocking.rs 2 3 66.67%
<!-- Total: 14 15 93.33% -->
Files with Coverage Reduction New Missed Lines %
src/blocking.rs 1 61.81%
src/async.rs 2 82.11%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 4772067577: 0.3%
Covered Lines: 837
Relevant Lines: 1039

💛 - Coveralls
coveralls commented 7 months ago

Pull Request Test Coverage Report for Build 4793145247

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/blocking.rs 2 3 66.67%
<!-- Total: 14 15 93.33% -->
Files with Coverage Reduction New Missed Lines %
src/blocking.rs 1 61.81%
src/async.rs 2 82.11%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 4772067577: 0.3%
Covered Lines: 837
Relevant Lines: 1039

💛 - Coveralls