Do not swallow error response

remix7531 commented 1 year ago

quick fix for issue #47

vladimirfomene commented 1 year ago

@remix75 , @tnull and @notmandatory this is ready for review.

vladimirfomene commented 11 months ago

I'm going to close this, the requested changes have been implemented in #58.

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 5534983433

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

68 of 111 (61.26%) changed or added relevant lines in 2 files are covered.
74 unchanged lines in 3 files lost coverage.
Overall coverage remained the same at 80.688%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/async.rs	54	70	77.14%
src/blocking.rs	14	41	34.15%
<!--	Total:	68	111	61.26%	-->

Files with Coverage Reduction	New Missed Lines	%
src/lib.rs	2	96.44%
src/async.rs	20	82.11%
src/blocking.rs	52	61.81%
<!--	Total:	74	-->

Totals
Change from base Build 5409842518:	0.0%
Covered Lines:	844
Relevant Lines:	1046

💛 - Coveralls

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 5619546090

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

38 of 127 (29.92%) changed or added relevant lines in 2 files are covered.
8 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-4.3%) to 76.349%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/async.rs	37	74	50.0%
src/blocking.rs	1	53	1.89%
<!--	Total:	38	127	29.92%	-->

Files with Coverage Reduction	New Missed Lines	%
src/async.rs	1	73.31%
src/blocking.rs	7	54.7%
<!--	Total:	8	-->

Totals
Change from base Build 5409842518:	-4.3%
Covered Lines:	849
Relevant Lines:	1112

bitcoindevkit / rust-esplora-client