refactor(blocking): replace ureq with minreq, update electrsd version

notmandatory commented 11 months ago

Since ureq still doesn't have an MSRV this PR refactors the blocking esplora client to use minreq.

I also replaced the dependency bitcoin-internals with the new hex-conservative crate.

notmandatory commented 11 months ago

Rebased on master.

TheBlueMatt commented 7 months ago

What's the status of this? We're trying to ship binary releases with esplora-client and really don't want to ship a huge pile of HTTP dependencies that we're then taking a responsibility for ensuring we keep up to date. With minreq at least it'd be one crate and we wouldn't have to monitor as many places.

nondiremanuel commented 7 months ago

@tnull will open a new PR for this, as we said during the Lib Team Call

TheBlueMatt commented 7 months ago

Just noticed ureq added a dependency on a "This is work in progress!" crate written and maintained entirely by a single author (that just broke our MSRV) - https://github.com/algesten/hoot/commits/main/. Definitely need to drop that ASAP :)

tnull commented 7 months ago

Just noticed ureq added a dependency on a "This is work in progress!" crate written and maintained entirely by a single author (that just broke our MSRV) - https://github.com/algesten/hoot/commits/main/. Definitely need to drop that ASAP :)

Note the single author in this case is the ureq maintainer/main author.

Anyways, reported the issue, they pushed out ureq 2.9.4 and introduced an MSRV guarantee of 1.61 within ~1hour. Still, will open a PR switching to minreq soon.

tnull commented 7 months ago

Now superseded by #75.

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 6385992408

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

112 of 149 (75.17%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+6.0%) to 85.361%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/blocking.rs	110	147	74.83%
<!--	Total:	112	149	75.17%	-->

Totals
Change from base Build 6378033331:	6.0%
Covered Lines:	898
Relevant Lines:	1052

bitcoindevkit / rust-esplora-client