bitcoindevkit / rust-esplora-client

Bitcoin Esplora API client library. Supports plaintext, TLS and Onion servers. Blocking or async.
MIT License
28 stars 44 forks source link

Keys in feerates mapping should be `u16`, not `String`. #64

Closed darosior closed 6 months ago

darosior commented 9 months ago

In get_fee_estimates the confirmation targets are passed as strings: https://github.com/bitcoindevkit/rust-esplora-client/blob/ef1925e1ee1b951f15a9339282858bea27c6168f/src/blocking.rs#L344-L365

But they are given as u16 by electrs: https://github.com/mempool/electrs/blob/b379d24cb1972976d4b787d6e4c0f664f144bfa6/src/new_index/query.rs#L196-L205 (mempool's fork), https://github.com/Blockstream/electrs/blob/fd35014283c7d3a7a85c77b9fd647c9f09de12c9/src/new_index/query.rs#L184-L193 (Blocktream's fork).