notmandatory
commented
8 months ago Please rebase to pick up changes in #69 that fix CI.
Open oleonardolima opened 9 months ago
notmandatory
commented
8 months ago Please rebase to pick up changes in #69 that fix CI.
oleonardolima
commented
8 months ago Most of the implementation is done, and it currently works on rust 1.70, also good to review and get inputs from it's being done.
But it does not work with our current MSRV, how do you usually go forward? just pin some of the dependencies?
cc @notmandatory @vladimirfomene
coveralls
commented
7 months ago | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| examples/tor.rs | 0 | 16 | 0.0% | ||
| src/async.rs | 104 | 123 | 84.55% | ||
| src/async_tor.rs | 0 | 267 | 0.0% | ||
| <!-- | Total: | 106 | 408 | 25.98% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| src/lib.rs | 1 | 97.08% | ||
| <!-- | Total: | 1 | --> |
| Totals | |
|---|---|
| Change from base Build 10514244019: | -16.3% |
| Covered Lines: | 1016 |
| Relevant Lines: | 1427 |
notmandatory
commented
6 months ago @oleonardolima can your rebase and rework this now that #75 is merged? hopefully not too big a change.
coderabbitai[bot]
commented
6 months ago This update introduces Tor support to the rust-esplora-client and rust-electrum-client by integrating arti-hyper, enhancing privacy and anonymity features. It includes adjustments to continuous integration workflows and expands the library's capabilities with asynchronous operations and Tor communication via new feature flags and client structures.
| Files | Change Summary |
|---|---|
.github/workflows/... |
Adjusted workflow configuration for Rust projects, including cache, toolchain setup, and testing. |
src/async.rs |
Extended AsyncClient to support asynchronous operations with Tor integration. |
src/lib.rs |
Expanded library to support anonymized async client with arti-hyper for Tor communication. |
| Objective | Addressed | Explanation |
|---|---|---|
Add Tor support using arti-hyper with feature async-arti-hyper (#61) |
✅ | |
| Utilize Arti features for HTTP-based requests integration, aligning with async streams (#61) | ✅ | |
Introduce async-arti-hyper feature flag for Tor support, maintaining compatibility with existing APIs (#61) |
✅ | |
Align implementation with existing APIs and usage patterns of rust-esplora-client (#61) |
✅ | |
| Consider a long-term strategy for support of different transport layers using a consistent API approach (#61) | ❓ | It's unclear if a long-term strategy for transport layer support has been explicitly outlined. |
This assessment concludes that the primary objectives have been largely met, with potential ambiguity regarding the strategic planning for future transport layer integrations.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
AsyncAnonymizedClient, that usesarti-hyper, andarti-clientto connect and do requests over the Tor network.fixes #61
Summary by CodeRabbit
AsyncClientwith multiple HTTP clients.AsyncAnonymizedClientfor anonymized requests using Tor.esplora_clientlibrary for anonymized asynchronous communication over Tor.