search

bitcoindevkit / rust-esplora-client

Bitcoin Esplora API client library. Supports plaintext, TLS and Onion servers. Blocking or async.
MIT License
28 stars 44 forks source link

update bitcoin to 0.31 #74

Closed getong closed 7 months ago

getong commented 7 months ago

This is a fix of #60 , which update rust to 1.67. It fix the ci error.

tnull commented 7 months ago

I don't think we want to bump the MSRV on this crate to 1.67.0. We will however need to find another way forward, e.g., by carefully pinning the respective offending dependency in CI (I think in this case it would be safe as it's just a downstream dependency of our electrsd test dependency I believe), or by introducing a script to download and run bitcoind/electrs as we did in LDK.

getong commented 7 months ago

I don't think we want to bump the MSRV on this crate to 1.67.0. We will however need to find another way forward, e.g., by carefully pinning the respective offending dependency in CI (I think in this case it would be safe as it's just a downstream dependency of our electrsd test dependency I believe), or by introducing a script to download and run bitcoind/electrs as we did in LDK.

I am afraid not.

electrum-client use bitcoin 0.31 from version 0.19. electrsd use electrum-client 0.19 from 0.27, so electrsd cannot be downstream here.

tnull commented 7 months ago

I don't think we want to bump the MSRV on this crate to 1.67.0. We will however need to find another way forward, e.g., by carefully pinning the respective offending dependency in CI (I think in this case it would be safe as it's just a downstream dependency of our electrsd test dependency I believe), or by introducing a script to download and run bitcoind/electrs as we did in LDK.

I am afraid not.

electrum-client use bitcoin 0.31 from version 0.19. electrsd use electrum-client 0.19 from 0.27, so electrsd cannot be downstream here.

I think there is a misunderstanding here: it's true we can't downgrade the electrsd dependency, but we can pin the dependencies downstream from it that do not meet the MSRV.

getong commented 7 months ago

I revert the code, but this error seems that it might be jobserver, I make a issue of it. rust-lang/jobserver-rs#69

tcharding commented 7 months ago

Hey mate, I pushed up #79 to do the upgrade which is getting past CI now.