Some tests of Base58 - Githubissues

bitcoinj-cash / bitcoinj

A library for working with Bitcoin

http://bitcoinj.cash

Apache License 2.0

64 stars 35 forks source link

Some tests of Base58 #45

Closed Danconnolly closed 6 years ago

coveralls commented 6 years ago

Coverage increased (+0.06%) to 71.179% when pulling 4a76d163e757e8fb607fb7d98c82f95fcbf7d051 on nchain-research:moretests into a7d8e3778cb800da905f5e64a69a6d92844aeb34 on bitcoinj-cash:cash-0.14.

HashEngineering commented 6 years ago

https://github.com/bitcoinj-cash/bitcoinj/blob/cash-0.14/core/src/test/java/org/bitcoinj/core/Base58Test.java

There are tests for Base58 already. This PR may be duplicating some of what is already present.

Danconnolly commented 6 years ago

ping @avilches

avilches commented 6 years ago

No worries, just reject the PR.