bitcoinj / secp256k1-jdk

Java library providing Bitcoin-related Elliptic Curve Cryptography
Apache License 2.0
8 stars 3 forks source link

Upgrade to JDK 22 #14

Closed msgilligan closed 6 months ago

msgilligan commented 6 months ago

This PR will resolve Issue #6 and Issue #9

This is WIP because the GitHub Actions build needs an update.

schildbach commented 6 months ago

I think if this PR is WIP it might be a good idea to use the GitHub "Draft" feature.

msgilligan commented 6 months ago

I think if this PR is WIP it might be a good idea to use the GitHub "Draft" feature.

We can't use it in a private repo without paying 😕

msgilligan commented 6 months ago

Approved. I only wonder why the jextract is under version control if it's generated as you say.

I think the recommend use of jextract is to get your initial implementation quickly, but then to customize it and maintain it manually. I think that is the path we will pursue. (If not, we can change things to run jextract as part of the build.)