search

bitcoinj / secp256k1-jdk

Java library providing Bitcoin-related Elliptic Curve Cryptography
Apache License 2.0
8 stars 3 forks source link

Rename modules and packages from `secp256k1` to not have terminal digit. #63

Closed msgilligan closed 2 weeks ago

msgilligan commented 3 months ago

We currently have warnings, like the following, in our build:

> Task :secp256k1-api:build

/home/runner/work/secp256k1-jdk/secp256k1-jdk/secp256k1-bouncy/src/main/java/module-info.java:16: warning: [module] module name component secp256k1 should avoid terminal digits
> Task :secp256k1-bouncy:compileJava
module org.bitcoinj.secp256k1.bouncy {
                   ^
1 warning

We should rename the packages and modules that currently contain secp256k1 to something that doesn't end with a digit. It could be either secp or secpjdk or something else. I'm leaning towards secpjdk because I've started informally shortening the project name to "secpjdk" because the full name is a mouthful.

msgilligan commented 3 weeks ago

Before doing this we should make the smaller change of renaming foreign to ffm, see: PR #69