GitHub gradle.yml workflow: use JDK 23

bitcoinj / secp256k1-jdk

Java library providing Bitcoin-related Elliptic Curve Cryptography

Apache License 2.0

9 stars 3 forks source link

GitHub gradle.yml workflow: use JDK 23 #92

Closed msgilligan closed 2 months ago

msgilligan commented 2 months ago

Our Gradle wrapper is already using Gradle 8.10, so JDK 23 is supported.

Use -PjavaToolchainVersion=23 on the Gradle command line in gradle.yml and leave the default value of javaToolchainVersion=22 (gradle.properties) for people using Nix or other environments that don't have JDK 23 available yet.

Update secp-examples-*/build.gradle to use javaToolchainVersion when configuring toolchains.

msgilligan commented 2 months ago

I must admit I don't really like different behaviour in different environments.

The default is JDK 22, the command-line flag can override. So the behavior doesn't change by environment but by a command-line flag.

But I get your point.

Approved anyway.

Thanks!