search

bitcoinjs / bip32

A BIP32 compatible library.
MIT License
181 stars 129 forks source link

chore: upgrade wif to v4.0.0 #81

Closed ChrisCho-H closed 1 year ago

ChrisCho-H commented 1 year ago

update wif following https://github.com/bitcoinjs/wif/pull/30 this will prevent error caused by crypto libs in browser or mobile

junderw commented 1 year ago

I would rather remove wif.

In a BIP32 world, wif is unnecessary.

Even if you need it, you can always do wif.encode(node.privateKey)

ChrisCho-H commented 1 year ago

bip32 has a function toWIF() which has a dependency on wif. do u think that module is also better to be removed?

junderw commented 1 year ago

Yes, that is what I meant when I said we should remove it.

It would be a breaking change, so I've been putting it off, I should have removed it when we updated for taproot.

ChrisCho-H commented 1 year ago

I made PR https://github.com/bitcoinjs/bip32/pull/82 to remove wif