search

bitcoinjs / bip38

BIP38 is a standard process to encrypt Bitcoin and crypto currency private keys that is less susceptible to brute force attacks thus protecting the user.
http://cryptocoinjs.com/modules/currency/bip38/
MIT License
208 stars 100 forks source link

Added progressCallback to function #15

Closed thehobbit85 closed 9 years ago

thehobbit85 commented 9 years ago

there is a built-in option in the scrypt module that allows the user to pass a progressCallback function in order to track the progress of of the encryption/decryption. It's extremely useful when trying to build any type of UI progress bar or something similar.

I also did some linting and fixed the Build badge link....

jprichardson commented 9 years ago

I like this. But why comment out the tests? https://github.com/thehobbit85/bip38/commit/d228d95321c1bd794e083a4b00aa7a79311adca2 Especially in a commit where it doesn't make sense to?

thehobbit85 commented 9 years ago

Since I'm an idiot who forgot to put them back :) I wanted to see why the build was failing so I only left the short test so that the build will go faster. Again, just to check something out and then I just forgot that... So here, I just returned them back to their place :)

thehobbit85 commented 9 years ago

I also made a small fix to the coverall script but now it seems this repo is not being tracked on coveralls so you also need to check that.

dcousens commented 9 years ago

@thehobbit85 for easy merging, if you could split up those non-progressCallback commits into other PRs so they can be merged straight away, that'd be awesome.

Also, rebase/squash your mistakes, :+1: