search

bitcoinjs / bip38

BIP38 is a standard process to encrypt Bitcoin and crypto currency private keys that is less susceptible to brute force attacks thus protecting the user.
http://cryptocoinjs.com/modules/currency/bip38/
MIT License
208 stars 100 forks source link

Some minor fixes and adding progressCallback functionality #16

Closed thehobbit85 closed 9 years ago

thehobbit85 commented 9 years ago
  1. Added progressCallback to module functions
  2. Added progressCallback explanation to the Readme
  3. Fixed problem with travis badge and added standard badge to readme
  4. Added coverage and logs to gitignore
  5. Small fix to npm coveralls script
dcousens commented 9 years ago

ACK on everything. LGTM.

dcousens commented 9 years ago

Tests are good, just coveralls dying for some reason. 91% coverage.

thehobbit85 commented 9 years ago

I think the coveralls die since the repo at coverall is still set to cryptocoinjs/bip38 instead of bitcoinjs/bip38. Need to fix that at coveralls.io

jprichardson commented 9 years ago

Thanks, reviewing...

jprichardson commented 9 years ago

Need to fix that at coveralls.io

Tried re-syncing coveralls... but bitcoinjs repo doesn't show up. @dcousens you may need to add it on your end because you're an owner?

dcousens commented 9 years ago

@jprichardson I think I enabled it. Time will tell.