search

bitcoinjs / bip38

BIP38 is a standard process to encrypt Bitcoin and crypto currency private keys that is less susceptible to brute force attacks thus protecting the user.
http://cryptocoinjs.com/modules/currency/bip38/
MIT License
208 stars 100 forks source link

Update index.js #24

Closed murbard closed 7 years ago

murbard commented 7 years ago

encrypt is calling encryptRaw with the wrong arity, as a result address was silently passed to progressCallback and progressCallback to scryptParams, because javascript is an unspeakable evil.

dcousens commented 7 years ago

Actually the bug is the inverse. address shouldn't be given at all... hence why it was passing the tests.

dcousens commented 7 years ago

Closing in favour of #25