Closed woodser closed 4 years ago
That being said. BIP38 is discouraged for implementation, so spending a lot of time on it is not priority. Though I would be open to adding async to it if you can get async merged in scryptsy. (I don't have merge rights there)
Made an async pull request for scryptsy https://github.com/cryptocoinjs/scryptsy/pull/13
It was merged and published in 2.1.0
I can start working on this.
Fair warning though... using async on scryptsy decreases performance. (we didn't get some sort of C implementation or WASM or something, we just added await promise setImmediate)
WIP that currently has all tests passing for Async methods (does not mean it's safe) is #50
Let me know if you have any questions and can help review.
3.1.0 published
BIP38 encryption should really be asynchronous. Otherwise the browser blocks and the user does not receive progress updates until after a key is fully encrypted.
I've implemented asynchronous support bip38 and scryptsy here and here for consideration.