v2.0 interface changes - Githubissues

bitcoinjs / bip38

BIP38 is a standard process to encrypt Bitcoin and crypto currency private keys that is less susceptible to brute force attacks thus protecting the user.

http://cryptocoinjs.com/modules/currency/bip38/

MIT License

208 stars 100 forks source link

v2.0 interface changes #5

Closed jprichardson closed 7 years ago

jprichardson commented 10 years ago

consider removing coinstring and only keeping raw methods, rename raw methods to encrypt/decrypt
consider removing class instantiation, pass script params as optional param
consider returning from raw privKey instead of privateKey

dcousens commented 9 years ago

Happy to do some work on this over the next few months or so

jprichardson commented 9 years ago

I'm not sure that any of the aforementioned are necessary. Although, I'm open to a case for any of them. One definite fix that's needed is the removal of the dependency aes now that crypto-browserify supports aes.

dcousens commented 9 years ago

See https://github.com/cryptocoinjs/bip38/pull/6