Closed rogerioyuuki closed 4 years ago
Thanks for the catch.
Just for record keeping sake:
Thank you so much. This is one reason why I think there needs to be more non-English-native developers in the crypto space.
I look forward to your continued contribution to the open source crypto community. It really helps us all. :+1:
Updated as v3.0.0
According to BIP38, the passphrase should be normalized:
But there isn't any treatment in this library. It should either be implemented or explicitly warned in the README.
Example (No Compression, No EC-multiply Test Vector 3): Unencrypted Key (WIF): 5Jajm8eQ22H3pGWLEVCXyvND8dQZhiQhoLJNKjYXk9roUFTMSZ4 Unencrypted Key (hex): 64eeab5f9be2a01a8365a579511eb3373c87c40da6d2a25f05bda68fe077b66e Passphrase ΟΜβππ© (\u03D2\u0301\u0000\U00010400\U0001F4A9) Encrypted Key: 6PRW5o9FLp4gJDDVqJQKJFTpMvdsSGJxMYHtHaQBF3ooa8mwD69bapcDQn