search

bitcoinjs / bip38

BIP38 is a standard process to encrypt Bitcoin and crypto currency private keys that is less susceptible to brute force attacks thus protecting the user.
http://cryptocoinjs.com/modules/currency/bip38/
MIT License
206 stars 100 forks source link

add safe-buffer as direct dependency #64

Closed faustbrian closed 4 years ago

faustbrian commented 4 years ago

This package can't be used with Plug'n'Play which is a feature of Yarn Berry because it relies on implicit dependencies.

bip38 tried to access safe-buffer, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

Required package: safe-buffer (via "safe-buffer")
Required by: bip38@npm:3.1.0 (via /Users/brian/Code/platform-sdk/.yarn/cache/bip38-npm-3.1.0-f2bcae6b96-2.zip/node_modules/bip38/)

Adding safe-buffer as a direct dependency resolves this issue.

junderw commented 4 years ago

Use ~5.1.1 instead. As that will match the version our dependencies are using.

faustbrian commented 4 years ago

@junderw updated

junderw commented 4 years ago

published as v3.1.1

faustbrian commented 4 years ago

Thanks for the quick release.