Version 3 - Githubissues

bitcoinjs / bip39

JavaScript implementation of Bitcoin BIP39: Mnemonic code for generating deterministic keys

ISC License

1.11k stars 447 forks source link

Version 3 #74

Closed dcousens closed 5 years ago

dcousens commented 6 years ago

[x] Isolation of wordlists from primary export (https://github.com/bitcoinjs/bip39/issues/71)
[x] Remove mnemonicToSeedHex, remove implicit hex support, Buffer only
[ ] Change to async pbkdf2, aka, async

fanatid commented 6 years ago

utACK

dabura667 commented 6 years ago

there are Japanese test cases linked in the BIP39 bip that I made.

timhwang21 commented 6 years ago

@dcousens just wondering is anything missing for this PR to be released? Would be happy to help if so! Also as my primary concern is bundle size would you consider a smaller PR that adds ESM bundling and/or exports all functions in separate files to allow cherry picking imports? Thanks!

wong2 commented 6 years ago

any progress?

junderw commented 5 years ago

Async is supported as a new method (backwards compatible) here: #100

junderw commented 5 years ago

Closing this in favor of #104

Async was added #100
Separation of wordlists was added to it #105

Separators are really not too necessary IMO... and as for removing HEX methods... yeah that makes sense.

I'll add these to the PR scope.