search

bitcoinjs / bip44-constants

This package provides BIP44 coin constants as found here: https://github.com/satoshilabs/slips/blob/master/slip-0044.md
MIT License
88 stars 63 forks source link

Latest constants #19

Closed kolya182 closed 6 years ago

kolya182 commented 6 years ago

Fixes https://github.com/bitcoinjs/bip44-constants/pull/17 https://github.com/bitcoinjs/bip44-constants/pull/18

fanatid commented 6 years ago

Thanks, do you need only BTR and X42?

kolya182 commented 6 years ago

We will need both.

fanatid commented 6 years ago

@kolya182 if you need only this two, I propose change only them. Currently slip-44 contains coins with same symbols (BCO = BitcoinOre / Bridgecoin) and some coin change their bip44 value.

kolya182 commented 6 years ago

@fanatid What if i remove BCO from this PR so we don't have duplicates in the list ?. And second question, how do you suggest to handle duplicates ?.

fanatid commented 6 years ago

If PR will not change current values I'm going merge and publish it ASAP

kolya182 commented 6 years ago

Looks good now ?

fanatid commented 6 years ago

@kolya182 is this will looks for you? https://github.com/bitcoinjs/bip44-constants/commit/6babbb1974202f30d65b16cc70c338dabdbe0c4b

kolya182 commented 6 years ago

@fanatid Yes

fanatid commented 6 years ago

Sorry for delay, new constants published in 5.2.0

kolya182 commented 6 years ago

@fanatid Спасибо. I think we can close these https://github.com/bitcoinjs/bip44-constants/pulls ?

fanatid commented 6 years ago

Closed.