search

bitcoinjs / bip44-constants

This package provides BIP44 coin constants as found here: https://github.com/satoshilabs/slips/blob/master/slip-0044.md
MIT License
88 stars 63 forks source link

Convert library into 2d Array #31

Closed junderw closed 5 years ago

junderw commented 5 years ago

Mentioned by @jprichardson

Changed README to reflect it.

jprichardson commented 5 years ago

Thank you.

  1. Can we remove the empty elements?
  2. Any reason we should keep the index as the first element?
junderw commented 5 years ago
  1. Yes.
  2. Not really.......... in fact, it's merely reflecting the constant minus 0x80000000... so it is redundant.
junderw commented 5 years ago
  1. Removed index from each row
  2. Removed rows where both symbol and name are empty strings

This is a major release. So I'll add changelog and version up to this PR.

junderw commented 5 years ago

OK, if everything looks good, I'll go ahead a push the tag and publish.

junderw commented 5 years ago

Fixes #29

Well... kinda...

fanatid commented 5 years ago

LGTM if works, hope that this solve all our issues with same symbols :) thanks @junderw !