BIP174 error caused CommonJS require to fail

koa202405 commented 2 months ago

Why you decide to set "type": "module", in package.json, this a huge broken change.

Edit (by @junderw) for context:

bitcoinjs-lib is currently in an RC release cycle for a new major version that is CommonJS/ESModule hybrid.
Users should be able to require in CommonJS and import in ESModules
This user most likely ran into some error, saw the ESModules change and assumed that was the problem.
The actual problem was bip174 CommonJS implementation being incomplete.
A fix has been released, and a job was created to check that the library can be required and imported, to prevent future breakage.

junderw commented 2 months ago

Can you be more specific about your issue?

Edit: Figured out the underlying issue. Next time please be more specific.

junderw commented 2 months ago

I fixed the issue in bip174 causing the error.

Since bitcoinjs-lib uses ^ dependencies, a re-install (or refresh of lockfile if you install from lockfiles) of bitcoinjs-lib will fix the issue.

bitcoinjs / bitcoinjs-lib