Update v6 branch: Add stripWitness to Transaction Issue 2169 #2170

bitcoinjs / bitcoinjs-lib

A javascript Bitcoin library for node.js and browsers.

MIT License

5.72k stars 2.11k forks source link

Closed JacksonDMiller closed 1 month ago

JacksonDMiller commented 1 month ago

This PR aligns the v6 branch with the recent changes to master.

This PR is intended to solve issue 2169

Adds a method to the transaction object to remove witness data.
- This is needed to construct a coinbase transaction with properly formatted inputs.
Adds a test to cover the new method.

junderw commented 1 month ago

Also, remove the audit CI job and the better-npm-audit dev dependency. (We got rid of it)

JacksonDMiller commented 1 month ago

Also, remove the audit CI job and the better-npm-audit dev dependency. (We got rid of it)

Done. I'd be happy to make a separate PR for this if you want, but it seems pretty safe.