search

bitcoinjs / bitcoinjs-lib

A javascript Bitcoin library for node.js and browsers.
MIT License
5.68k stars 2.1k forks source link

Add BIP49 tests and example #824

Closed iancoleman closed 7 years ago

iancoleman commented 7 years ago

Does bitcoinjs-lib support BIP49 (Derivation scheme for P2WPKH-nested-in-P2SH based accounts)?

If so, tests for the bip49 vectors would be great to have, and make for a useful example.

https://github.com/bitcoin/bips/blob/master/bip-0049.mediawiki#test-vectors

dcousens commented 7 years ago

Does bitcoinjs-lib support BIP49

bitcoinjs-lib will likely not directly support this, but it could definitely be a new module under the bitcoinjs organization.

This isn't any specific opinion of BIP49, simply that we even want to move BIP32 to bitcoinjs/bip32.

I suspect, given that BIP49 is a derivation scheme for BIP32, you'll sooner see that scheme in the above or bitcoinjs/bip32-utils.

dcousens commented 7 years ago

@iancoleman that said, an integration example could definitely be added to showcase how you might do it as is. :+1: Even with bip32 put in its own module, I can't see it not being bundled in bitcoinjs for a few major versions yet.

dcousens commented 7 years ago

Closing in favour of https://github.com/bitcoinjs/bitcoinjs-lib/pull/840