search

bitcoinjs / bolt11

A library for encoding and decoding lightning network payment requests as defined in BOLT #11.
MIT License
93 stars 65 forks source link

Initial implementation #1

Closed junderw closed 6 years ago

junderw commented 6 years ago

This implements encode and decode.

tests include test vectors from the BOLT#11 and have checks for decoding, making sure the info is correct, then encoding and making sure the payment request is the same with both reconstruction AND signing (RFC6979 deterministic signing)

Help Wanted:

Anyone who can list of cases I should add for tests, as well as any refactoring help please feel free to commit directly to the wip branch.

Thanks.

junderw commented 6 years ago

Also, I copied convert from bech32, but there is currently a PR I have open to expose convert.

https://github.com/bitcoinjs/bech32/pull/18

Once this is merged I will replace convert with bech32.convert

dcousens commented 6 years ago

Travis has been enabled on the repo, but unclear if that PR needed to merge master to work here.

dcousens commented 6 years ago

Still need to review this in depth, but, no use holding back development in this PR.