search

bitcoinjs / bolt11

A library for encoding and decoding lightning network payment requests as defined in BOLT #11.
MIT License
92 stars 64 forks source link

Simnet support #26

Closed mrfelton closed 4 years ago

mrfelton commented 4 years ago

As a follow up to https://github.com/bitcoinjs/bolt11/issues/19 this PR updates coininfo package to a version that supports simnet and adds simnet support into the bolt11 library itself.

This makes it easier to use with simnet as the user doesn't need to do manually parse the payment request and figure out which bech32 code they need to manually pass into the decode method.

mrfelton commented 4 years ago

note: there is a PR with these changes open against coininfo https://github.com/cryptocoinjs/coininfo/pull/89

bucko13 commented 4 years ago

Any chance of this getting merged in? It looks like simnet support is now in coininfo (here). decode is currently breaking for tests I have in a project for LSAT based authentication because of this unfortunately.

bucko13 commented 4 years ago

Nevermind. I saw there's support for "unknown network" where you can add the bech32 prefix. Still think it would be worthwhile to officially add it in now that it's supported in coininfo too, especially since btc simnet doesn't really feel like it should be counted as "unknown".

junderw commented 4 years ago

closed in favor of #33