search

bitcoinjs / bolt11

A library for encoding and decoding lightning network payment requests as defined in BOLT #11.
MIT License
92 stars 64 forks source link

Initial implementation of payment secret and feature bits #34

Closed junderw closed 3 years ago

junderw commented 4 years ago

Still need to write tests.

@alexbosworth #30

The BOLT11 description is kind of vague. So the conditions for throwing errors etc. are unclear.

junderw commented 4 years ago

See also https://github.com/lightningnetwork/lightning-rfc/pull/747

mrfelton commented 3 years ago

Keen to see this one merged. Can't pay to recent lnd nodes without this

mrfelton commented 3 years ago

rebased on master

junderw commented 3 years ago

This LGTM from a conceptual standpoint.

However, we need to test this. If you could help by gathering some examples and decoding them so we can see if the decoded data makes sense, then we can create some tests from them using the decoded data and modifying them to trigger all the Errors that are in the logic.