chore: upgrade to bitcoinjs-lib v6

bitcoinjs / bolt11

A library for encoding and decoding lightning network payment requests as defined in BOLT #11.

MIT License

92 stars 64 forks source link

chore: upgrade to bitcoinjs-lib v6 #53

Closed motorina0 closed 2 years ago

motorina0 commented 2 years ago

Summary

update dependency for bitcoinjs-lib to v6
fix one broken test (see comment for commit https://github.com/bitcoinjs/bolt11/commit/b34dd0a23d0a051f824eb4719477c5cb09ba4332)
parser now allows fallback_address.code to be 1
add unit tests for witness v1 fallback_adress

Closes: https://github.com/bitcoinjs/bolt11/issues/52

junderw commented 2 years ago

Also, don't forget package version bump in lock file too.

motorina0 commented 2 years ago

Also, don't forget package version bump in lock file too.

Done!

junderw commented 2 years ago

Published to v1.3.3

secp256k1 dependency was having trouble building on v14 so I updated it.

motorina0 commented 2 years ago

Published to v1.3.3

secp256k1 dependency was having trouble building on v14 so I updated it.

hmmm, tests fail for me with:

const sigObj = secp256k1.sign(payReqHash, privateKey) ^

TypeError: secp256k1.sign is not a function at Object.sign (/Users/moto/Documents/GitHub/bitcoincoretech/bolt11/payreq.js:533:28) at Test. (/Users/moto/Documents/GitHub/bitcoincoretech/bolt11/test/index.js:89:33)

junderw commented 2 years ago

oops

my bad.

published v1.3.4