search

bitcoinjs / bolt11

A library for encoding and decoding lightning network payment requests as defined in BOLT #11.
MIT License
92 stars 64 forks source link

Return all route hints in tagsObject #74

Closed bufo24 closed 1 month ago

bufo24 commented 1 month ago

Previously routing_info in tagsObject only had 1 route hint, while this could be multiple regarding to the bolt11 spec. I changed the routing_info to be an array inside the tagsObject.

I am aware of this being a breaking change, but I got quite confused that this was not an array before so I hope this change gives a more accurate representation of how route hints are being using in lightning invoices.

junderw commented 1 month ago

I don’t think this is a good idea.

This is a signed data structure. Messing around with order is never a good idea.